Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>
Subject: Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT
Date: 2022-06-02 09:14:47
Message-ID: CAPmGK15E_LGBmdAS-nvJfphOK7Baj1UTg1N-=uy1cYFzRp_Kbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 2, 2022 at 10:23 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Tue, May 31, 2022 at 9:35 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > > I would probably just update the synopsis. It's not very hard to
> > > figure out what's likely to happen even without clicking through the
> > > link, so it seems like it's just being long-winded to duplicate the
> > > stuff here. But I don't care much if you feel otherwise.
> >
> > It looks like there are pros and cons. I think it’s a matter of
> > preference, though.
> >
> > I thought it would be an improvement, but I agree that we can live
> > without it, so I changed my mind; I'll go with my version. I think we
> > could revisit this later.
>
> I guess I'm fine with leaving the text as-is, though slightly bothered
> by leaving the phrase "partition of the given parent table with
> specified partition bound values" to also cover the DEFAULT partition
> case.

I think we should discuss this separately, maybe as a HEAD-only patch,
so I pushed my version, leaving the description as-is.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Geier 2022-06-02 09:30:31 Re: Assertion failure with barriers in parallel hash join
Previous Message Thibaud W. 2022-06-02 09:12:46 Proposal: adding a better description in psql command about large objects