| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Zhenwei Shang <a934172442(at)gmail(dot)com> |
| Cc: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, efujita(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix column name escaping in postgres_fdw stats import |
| Date: | 2026-05-14 08:47:17 |
| Message-ID: | CAPmGK153uG4k4KJuBE6nDPMMjjYyf0Bt9m6r=1LSWta6bnsVJg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 13, 2026 at 8:22 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Wed, May 13, 2026 at 4:27 PM Zhenwei Shang <a934172442(at)gmail(dot)com> wrote:
> > The patch overall looks solid to me. A tiny suggestion, while here, would it make sense to also add comma and brace column names to the test, as they are classic array-literal hazards, like “col,comma” and “col{brace”?
> Those cases are handled correctly even without the patch, so sorry, I
> don't feel the need to extend the test further.
Pushed. I didn't extend the test, but I think we could do so later if needed.
I closed the entry in the PG20-1 CF as well as the open item.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-05-14 08:49:09 | Re: Add a greedy join search algorithm to handle large join problems |
| Previous Message | Tatsuo Ishii | 2026-05-14 07:53:23 | Re: Should IGNORE NULLS cache nullness for volatile arguments? |