Re: Asynchronous Append on postgres_fdw nodes.

On Mon, Mar 8, 2021 at 2:05 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> There seems to be no objections, so I went ahead and added the
> table/server option ‘async_capable’ set false by default. Attached is
> an updated patch.

Attached is an updated version of the patch. Changes are:

* I modified nodeAppend.c a bit further to make the code simpler
(mostly, ExecAppendAsyncBegin() and related code).
* I added a function ExecAsyncRequestPending() to execAsync.c for the
convenience of FDWs.
* I fixed a bug in the definition of WAIT_EVENT_APPEND_READY in pgstat.h.
* I fixed a bug in process_pending_request() in postgres_fdw.c.
* I added comments to executor/README based on Robert’s original patch.
* I added/adjusted/fixed some other comments and docs.
* I think it would be better to keep the existing test cases in
postgres_fdw.sql as-is for testing the existing features, so I
modified it as such, and added new test cases for testing this
feature.
* I rebased the patch against HEAD.

I haven’t yet added docs on FDW APIs. I think the patch would need a
bit more comments. But other than that, I feel the patch is in good
shape.

Best regards,
Etsuro Fujita