From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
---|---|
To: | Gilles Darold <gilles(at)darold(dot)net> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |
Date: | 2019-11-08 08:25:52 |
Message-ID: | CAPmGK14TAjv94jGvtPJVf=d067F=XfgmA3F=+3dZTgFMDuCtaA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Gilles,
Sorry, I have sent an unfinished email.
On Fri, Nov 8, 2019 at 5:20 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, Nov 8, 2019 at 4:55 PM Gilles Darold <gilles(at)darold(dot)net> wrote:
> > Le 07/11/2019 à 11:52, Etsuro Fujita a écrit :
> > > On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
> > > <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > >> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
> > >> contains the same mistake and needs more or less the same fix.
> > > Good catch! How about rewriting "We disallow remote transactions that
> > > modified anything" in the comment simply to "We disallow any remote
> > > transactions" or something like that? Attached is an updated patch.
> > > In the patch, I did s/prepare/PREPARE/ to the error message as well,
> > > as you proposed.
>
> > Looks good for me,
Pushed after modifying the commit message a bit. Thanks!
Best regards,
Etsuro Fujita
From | Date | Subject | |
---|---|---|---|
Next Message | Kuntal Ghosh | 2019-11-08 08:52:32 | Re: Ordering of header file inclusion |
Previous Message | Etsuro Fujita | 2019-11-08 08:20:33 | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |