| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, efujita(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix column name escaping in postgres_fdw stats import |
| Date: | 2026-05-12 07:36:12 |
| Message-ID: | CAPmGK14OT=w+rLm9cgzhwR9oAmDD4Kfj-Z7nQEH4J9NNp4inbw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ayush,
On Mon, May 4, 2026 at 7:24 AM Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> Are there some edits you would like me to make on the patch?
One thing I noticed is the test case you added; it only tests
departing column names with single quotes, but it's better to also
test that with backslashes, to confirm the patch addresses the issue
in [1] as well. So I updated the patch as such. New version
attached. Other than that the patch looks good to me, so I'll push it
if no objections from you (or anyone else).
> Or would you like me to add the thread link to open items for 19?
I added this thread to an existing open item as the second report.
Sorry for the delay.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-column-name-escaping-in-postgres_fdw-stats-import-efujita.patch | application/octet-stream | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-05-12 07:57:29 | Re: Adding REPACK [concurrently] |
| Previous Message | jian he | 2026-05-12 07:06:46 | Re: on_error table, saving error info to a table |