Re: [PATCH] Fix column name escaping in postgres_fdw stats import

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, efujita(at)postgresql(dot)org
Subject: Re: [PATCH] Fix column name escaping in postgres_fdw stats import
Date: 2026-05-12 08:02:44
Message-ID: CAJTYsWU_sSnyTrdQCeMx8RoMuZAyocNt5fCOd4yw-tpE12JXTQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujita-san,

On Tue, 12 May 2026 at 13:06, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:

> Hi Ayush,
>
> On Mon, May 4, 2026 at 7:24 AM Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
> wrote:
> > Are there some edits you would like me to make on the patch?
>
> One thing I noticed is the test case you added; it only tests
> departing column names with single quotes, but it's better to also
> test that with backslashes, to confirm the patch addresses the issue
> in [1] as well. So I updated the patch as such. New version
> attached. Other than that the patch looks good to me, so I'll push it
> if no objections from you (or anyone else).
>
>
Thanks for the updated version, and for folding in the backslash case
from [1].

I confirmed that the patch applies cleanly on master and that
make -C contrib/postgres_fdw check passes, including the new
dtest_ftable case. The merged test seems a strict improvement.

No objections from me.

Regards,
Ayush

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2026-05-12 08:09:23 Re: Function scan FDW pushdown
Previous Message Amit Kapila 2026-05-12 07:57:29 Re: Adding REPACK [concurrently]