| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Several issues with postgres_fdw stats import |
| Date: | 2026-09-22 11:38:52 |
| Message-ID: | CAPmGK14OBMkMEkanHdA9+JdrZLGzfNRcEVmb6K4DtDe_CTTTqw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 11, 2026 at 12:46 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
> On Thu, Sep 10, 2026 at 11:02 AM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> From a cost calculation perspective, I think it's appropriate to use
>> the imported relpages as-is, as it's used to estimate the cost for
>> remote operations, not local ones, and thus we should actually instead
>> fix the normal-ANALYZE handling to calculate the size based on the
>> remote definition of block size.
>
> +1
I expanded a comment to mention this. Attached is a patch for that.
I will push and back-patch the patch if no objections.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| improve-stats-import-comments.patch | application/octet-stream | 710 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yao Feng | 2026-09-22 11:49:00 | Re: [GSoC 2026] - B-tree Index Bloat Reduction - Approach & Questions |
| Previous Message | Etsuro Fujita | 2026-09-22 11:35:58 | Re: Several issues with postgres_fdw stats import |