| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Lev Nikolaev <lev(dot)nikolaev(at)tantorlabs(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] analyze: move elevel calculation into do_analyze_rel() |
| Date: | 2026-04-02 11:14:37 |
| Message-ID: | CAPmGK14Mxuv+O7WauBEDN6usnPq77E=p90FU3C22=QJcQogMpA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 2, 2026 at 8:29 AM Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> On 3/31/26 7:56 PM, Lev Nikolaev wrote:
> > I reworked the patch slightly.
>
> This small cleanup makes sense to me since do_analyze_rel() already
> looks at if VACOPT_VERBOSE is set meaning related code is grouped closer
> after this small refactoring.
>
> The patch no longer applied so I rebased it.
Sorry, but -1 from me because this change would lead to doing the same
setup repeatedly when analyzing inheritance trees, which is not great.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-04-02 11:26:32 | Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE |
| Previous Message | Etsuro Fujita | 2026-04-02 11:05:41 | Re: Import Statistics in postgres_fdw before resorting to sampling. |