Re: Update comments in functions for statistics import in postgres_fdw.c

On Wed, Nov 11, 2026 at 9:39 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > On Nov 10, 2026, at 18:04, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Tue, Nov 10, 2026 at 6:50 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> >> As I understand it, you are saying we need to separate the version
> >> parameter from statistical value parameters, but the comment for
> >> import_attribute_statistics says:
> >>
> >> * Import attribute statistics from NullableDatum inputs for all statistical
> >> * values.
> >> *
> >> * For now, the 'version' argument is ignored. In the future it can be used
> >> * to interpret older statistics properly.

> > I mean the term "statistical values" includes a version value. Sorry.

> I was considering the version parameter as metadata for the statistical values, which could be used to distinguish between different sets of statistical values. But I see your point now. Treating the version parameter as a statistical value parameter also makes sense to me. No objection from my side.

On reflection I changed my mind. As pointed out by you, what I
proposed isn't very clear. So I modified the patch based on your idea
(ie, s/statistical value parameters/NullableDatum arguments/), then
pushed/back-patched it.

Thanks again!

Best regards,
Etsuro Fujita