From: | Martín Marqués <martin(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: pg_dump with tables created in schemas created by extensions |
Date: | 2016-08-26 22:12:15 |
Message-ID: | CAPdiE1zhfye5JRcW9wmuaYCPZ+OWABAT6g-6czOYBw5mstH-=g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
2016-08-26 10:53 GMT-03:00 Martín Marqués <martin(at)2ndquadrant(dot)com>:
>
> There's still one issue, which I'll add a test for as well, which is
> that if the index was created by the extension, it will be dumped
> anyway. I'll have a look at that as well.
Looking at this issue today, I found that we are not setting a
dependency for an index created inside an extension. I don't know if
it's deliberate or an overlook.
The thing is that we can't check pg_depend for dependency of an index
and the extension that creates it.
I was talking with other developers, and we kind of agree this is a
bug, for 2 reasons we thought of:
*) If the extension only creates an index over an existing table, a
drop extension will not drop that index
*) We need to have the dependency for this patch as well, else we'll
end up with an inconsistent dump, or at least one that could restore
with a != 0 return error code.
I'll open a separate bug report for this.
Regards,
--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-08-26 22:37:53 | Re: pg_dump with tables created in schemas created by extensions |
Previous Message | Andres Freund | 2016-08-26 22:00:26 | Re: pgsql: Change the way that LWLocks for extensions are allocated. |