Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement

>
> In support of this, I have tried testing after making a small change
> in the function pg_get_trigger_ddl() in ruleutils.c:
>
> Instead of this:
> /*Parse the trigger name to handle quoted identifiers */
> nameList = textToQualifiedNameList(trgName);
> if (list_length(nameList) != 1)
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("trigger name cannot be schema qualified")));
> DeconstructQualifiedName(nameList, &schemaName, &objName);
>
>
Thanks for taking a look Soumya.

I believe these DDL functions now live in ddlutils.c and include a new
parameter for adding a "pretty" flag is required. I am in the middle of
developing a patch for that, but I took your fix into consideration.

> Do: objName = text_to_cstring(trgName); to treat the trigger name
>

I think this makes sense.

I also will need to make a few adjustments to get the pretty printing
functionality working. Since my patch essentially borrows from
pg_get_triggerdef_worker, it will need some work.

--
Best,
Phil Alger
EDB: https://www.enterprisedb.com