| From: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
|---|---|
| To: | zhong950419(at)gmail(dot)com |
| Cc: | zsolt(dot)parragi(at)percona(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, manuelreyesbravo(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, masao(dot)fujii(at)gmail(dot)com, daria(dot)n(dot)lepikhova(at)gmail(dot)com, ayushtiwari(dot)slg01(at)gmail(dot)com |
| Subject: | Re: Assertion failure in WAL summarizer |
| Date: | 2026-11-18 13:04:51 |
| Message-ID: | CAPHduZDT4Wh1kfQSj149ybvpYGCbSC-6PK9WNg11ivgJUC_pRw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shihao,
I re-ran the reproduction from my earlier mail against v6 (REL_18_STABLE
4d6ff8a051 + v6-0001..0003): the standby runs the unpatched summarizer,
then the promoted server is restarted on 18 + v6.
The timeline 1 summary is the same as before (0/02000028-0/030051F0, ending
at the switch point 0/30051F0). The incremental backup and pg_combinebackup
succeed, and the restored table now matches the promoted server (1|0 2|0
3|0 4|1), where v5 gave 4|0.
With v6-0002's check changed back to `ws->end_lsn > tli_end_lsn`, the
restored table is stale again (4|0), so the `>=` is what fixes it. The
control case, with v6 binaries on the standby from the start, also restores
correctly.
I didn't run the new
https://www.google.com/url?q=http://015_summary_past_switch.pl&source=gmail&ust=1795093490688000&sa=E
in this build.
Thanks,
Sai Pranav
On Tue, Nov 17, 2026 07:07 AM, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Hi Zsolt and Raja,
>
> Thanks for the review! I appreciate it!
>
> In v6, 0002 also checks a summary that ends at the switch point. It
> no longer raises an error. Instead it backs up any relation fork that
> such a summary truncates in full. That only costs space in an
> incremental backup whose prior backup is older than the promotion.
>
> Thanks,
> Shihao
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-11-18 13:11:32 | RE: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Previous Message | Heikki Linnakangas | 2026-11-18 12:52:11 | Re: GetRelationPath() vs critical sections |