Re: htup header reorganization breaks many extension modules

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: htup header reorganization breaks many extension modules
Date: 2012-09-26 04:08:07
Message-ID: CAP7Qgm=8-7JWb-HfLZzXwzdJGL627Nram6-JQOk7D25q4_HeDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 25, 2012 at 5:30 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> I haven't followed the details of the htup header reorganization, but I
> have noticed that a number of external extension modules will be broken
> because of the move of GETSTRUCT() and to a lesser extent
> heap_getattr(). Of course some #ifdefs can fix that, but it seems
> annoying to make everyone do that. Maybe this could be reconsidered to
> reduce the impact on other projects.
>

But it's only add #include "access/htup_details.h"? I'd not argue
it's harmful unless I missed your point.

Thanks,
--
Hitoshi Harada

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daymel Bonne Solís 2012-09-26 05:17:07 system_information.triggers & truncate triggers
Previous Message Peter Eisentraut 2012-09-26 02:34:55 Re: _FORTIFY_SOURCE by default?