| From: | Lukas Fittl <lukas(at)fittl(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Gaurav Singh <gaurav(dot)singh(at)yugabyte(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Memory leak in pg_stat_statements when qtext file contains invalid encoding |
| Date: | 2026-03-27 15:25:47 |
| Message-ID: | CAP53PkwciXaP2TQLjkjLGHD1+HEtBfCcpfd25xCnGbgQErpocA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Mar 27, 2026 at 4:13 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 27/03/2026 11:05, Daniel Gustafsson wrote:
> >> On 27 Mar 2026, at 09:59, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> >
> >> Hmm, perhaps. But there's a simpler, less invasive fix. When that code was written, we didn't have MCXT_ALLOC_HUGE nor MCXT_ALLOC_NO_OOM. Now that we do, we can just use palloc_extended(MCXT_ALLOC_HUGE | MCXT_ALLOC_NO_OOM) instead of raw malloc(). Per attached.
> >
> > LGTM.
>
> Committed, thanks!
Thanks for the quick fix!
TIL about MCXT_ALLOC_NO_OOM, that's useful to know about.
Thanks,
Lukas
--
Lukas Fittl
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-27 17:41:29 | Re: BUG #19438: segfault with temp_file_limit inside cursor |
| Previous Message | Dmytro Astapov | 2026-03-27 12:29:12 | array_agg(anyarray) silently produces corrupt results with parallel workers when inputs mix NULL and non-NULL array elements |