| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Subject: | Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls |
| Date: | 2025-10-20 04:45:01 |
| Message-ID: | CAOzEurTyHYZXYckrZ-OsXrXjG9nnAVqsmBsLey8mD7ZnJdh8-w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 20, 2025 at 10:17 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Sun, Oct 19, 2025 at 2:04 AM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> > Thank you for the patch. I have one comment.
> >
> > + if (lag_tracker->overflowed[head].lsn > lsn)
> > + return now - lag_tracker->overflowed[head].time;
> >
> > Could this return a negative value if the clock somehow went
> > backwards? The original code returns -1 in this case, so I'm curious
> > about this.
>
> Thanks for the review!
>
> Yes, you're right. So I've updated the patch so that -1 is returned
> when the current time is earlier than the time in the overflow entry,
> treating it as "no new sample found".
Thank you for updating the patch. It looks nice to me.
--
Best regards,
Shinya Kato
NTT OSS Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 正华吕 | 2025-10-20 04:46:13 | Question on ThrowErrorData |
| Previous Message | Michael Paquier | 2025-10-20 04:32:44 | Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE |