Re: Add backup_type to pg_stat_progress_basebackup

On Sat, Aug 2, 2025 at 8:12 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Jul 22, 2025 at 2:42 AM Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> >
> > On Tue, Jul 22, 2025 at 6:06 PM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > >
> > > On Tue, 22 Jul 2025 17:48:35 +0900
> > > Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> > >
> > > > Hi hackers,
> > > >
> > > > Starting with PostgreSQL 17, pg_basebackup supports incremental
> > > > backups. However, the pg_stat_progress_basebackup view doesn't
> > > > currently show the backup type (i.e., whether it's a full or
> > > > incremental backup).
> > > >
> > > > Therefore, I propose adding a backup_type column to this view. While
> > > > this information is available in pg_stat_activity, the backup type is
> > > > important for monitoring the progress of pg_basebackup, and including
> > > > it directly in the progress view would be very useful.
> > > >
> > > > Thoughts?
> > >
> > > That seems reasonable to me.
>
> I like this idea.

Thank you for reviewing my patch!

> > Thank you for the review.
> > I made a careless mistake. Fixed.
>
> The patch seems reasonably simple and looks good to me. I've updated
> the comment in bbsink_progress_new() and attached the modified version
> patch (with the commit message). Please review it.

Thanks for the patch. I reviewed it, and LGTM.

--
Best regards,
Shinya Kato
NTT OSS Center