Re: Add log_autovacuum_{vacuum|analyze}_min_duration

From: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
To: Michael Banck <mbanck(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add log_autovacuum_{vacuum|analyze}_min_duration
Date: 2025-06-03 08:25:40
Message-ID: CAOzEurRw3O5xusOkD4fqDYZGfvQbvpoc0-XGuAgiAQ4UWMLv0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for the comment!

On Tue, Jun 3, 2025 at 4:42 PM Michael Banck <mbanck(at)gmx(dot)net> wrote:
>
> Hi,
>
> On Tue, Jun 03, 2025 at 03:35:20PM +0900, Shinya Kato wrote:
> > I am proposing the introduction of two new GUC parameters,
> > log_autovacuum_{vacuum|analyze}_min_duration, to replace the existing
> > log_autovacuum_min_duration.
>
> How about adding log_autoanalyze_min_duration instead? That would still
> slightly retcon the log_autovacuum_min_duration meaning/semantics by no
> longer logging autoanalyze unless the new GUC is set, but at least not
> rename the GUC and make both shorter while still being comprehensible
> IMO. Not sure what others think?

I surely think adding log_autoanalyze_min_duration is simpler and
shorter, but the reason I chose this GUC name is for consistency with
other autovacuum parameters. Existing autovacuum parameters that have
separate settings for vacuum and analyze operations follow the pattern
autovacuum_{vacuum|analyze}_*.
https://www.postgresql.org/docs/devel/runtime-config-vacuum.html#RUNTIME-CONFIG-AUTOVACUUM

Shinya Kato
NTT OSS Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-06-03 08:28:14 Re: Suggestions for improving \conninfo output in v18
Previous Message Michael Paquier 2025-06-03 08:09:18 Re: Improve explicit cursor handling in pg_stat_statements