Re: Use IsA() macro instead of nodeTag comparison

On Fri, Jan 9, 2026 at 9:56 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> > I found a similar issue in define.c. Should we fix it there as well?
> >
> > diff --git a/src/backend/commands/define.c b/src/backend/commands/define.c
> > index 63601a2c0b4..8313431397f 100644
> > --- a/src/backend/commands/define.c
> > +++ b/src/backend/commands/define.c
> > @@ -349,7 +349,7 @@ defGetStringList(DefElem *def)
> > (errcode(ERRCODE_SYNTAX_ERROR),
> > errmsg("%s requires a parameter",
> > def->defname)));
> > - if (nodeTag(def->arg) != T_List)
> > + if (!IsA(def->arg, List))
> > elog(ERROR, "unrecognized node type: %d", (int)
> > nodeTag(def->arg));
> >
> > foreach(cell, (List *) def->arg)
> >
>
> Yep, I did a search with `nodeTag\(.*\)\s+(?:!=|==).*`, and this is the only finding.

Oh, I missed that, sorry. Thanks, LGTM.

--
Best regards,
Shinya Kato
NTT OSS Center