| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | songjinzhou <tsinghualucky912(at)foxmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: file_fdw: Support multi-line HEADER option. |
| Date: | 2026-01-15 07:14:35 |
| Message-ID: | CAOzEurRY+GAVP12rKjAm3XzzkOnAODV7x_rN-CQ97jpB_PEaSg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 9, 2026 at 9:51 PM songjinzhou <tsinghualucky912(at)foxmail(dot)com> wrote:
> I tested the patch and have no functional questions. I have a small question: Is it necessary to add "(also as a string, to support file_fdw options)" to the final `ereport` error message in `defCheckCopyHeaderString`? Like in one of your comments below.
Thank you for reviewing my patch and the comment!
I don’t think we should add “(also as a string, to support file_fdw
options)” to the ereport message because PostgreSQL error messages
typically describe the semantic type rather than the input format.
For instance, REJECT_LIMIT accepts a string in file_fdw but the error
message simply asks for a numeric value.
--
Best regards,
Shinya Kato
NTT OSS Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-15 07:20:14 | Re: [PATCH] psql: add \dcs to list all constraints |
| Previous Message | lchch1990@sina.cn | 2026-01-15 07:13:42 | Re: Can we change pg_rewind used without wal_log_hints and data_checksums |