| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Wake up backends immediately when sync standbys decrease |
| Date: | 2026-02-01 06:24:45 |
| Message-ID: | CAOzEurRXO6rEhYRh0tcQha+fxQw3X9EYSV=zMnG1D9Ebnnarng@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for the reviews!
On Sat, Jan 31, 2026 at 12:28 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> This issue can occur not only when the number of sync standbys is reduced,
> but also when the configured standby names change. For example, if the config
> changes from "FIRST 2 (sby1, sby2)" to "FIRST 2 (sby1, sby3)",
> waiters on sby2 should be released immediately. But, currently, there can
> a delay before that happens. Right?
Yes, you're right, so I revised the comments and commit message.
> > My main concern is code duplication. The same block is added in three places. While the existing reload handling is already duplicated there, adding more logic on top makes the situation a bit worse from a maintenance perspective.
> >
> > Would it make sense to factor the reload handling into a small helper, for example:
>
> +1
I've updated it in the v2 patch.
--
Best regards,
Shinya Kato
NTT OSS Center
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Wake-up-backends-immediately-when-synchronous_sta.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Pavel Stehule | 2026-02-01 05:09:25 | Re: slow SELECT expr INTO var in plpgsql |