| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Sami Imseih <samimseih(at)gmail(dot)com> |
| Subject: | Re: Add mode column to pg_stat_progress_vacuum |
| Date: | 2025-10-09 11:31:57 |
| Message-ID: | CAOzEurQd2TFM_MQPZYUTe_61iv54ia7x4=R-Nye+6DFnCxYdxg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 8, 2025 at 12:04 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> > I was able to manually verify the failsafe mode's behavior by using
> > the existing test script at
> > src/test/modules/xid_wraparound/t/001_emergency_vacuum.pl. This script
> > successfully triggered the failsafe condition and the view reported
> > the correct mode. However, I found this test to be somewhat flaky in
> > my environment and decided not to add it to the patch to avoid
> > introducing a potentially unstable test into the tree.
>
> Perhaps there's something we can do with injection points to improve the
> stability of the test.
Thank you for the advice. You're right, I can test it with injection
point. However, many other progress reporting views do not have
regression tests, so I do not have to add a regression test of
pg_stat_progress_report.
--
Best regards,
Shinya Kato
NTT OSS Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinya Kato | 2025-10-09 11:35:54 | Re: Add mode column to pg_stat_progress_vacuum |
| Previous Message | Shayon Mukherjee | 2025-10-09 11:20:32 | Re: [PATCH] Proposal: Allow reads to proceed during FK/trigger drops by reducing relation-level lock from AccessExclusive to ShareRowExclusive |