Re: Add mode column to pg_stat_progress_vacuum

From: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, maciek(at)sakrejda(dot)org, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add mode column to pg_stat_progress_vacuum
Date: 2025-12-05 04:29:54
Message-ID: CAOzEurQT9dd59au+EbXN_huX8NLYoEPZJiUxyODdUKGstViJ0Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for the review!

On Thu, Dec 4, 2025 at 9:15 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've attached a small change to simplify the 0001 patch. Please review it.

LGTM, and I've updated in v9 patches.

> Here are a few comments:
>
> + <listitem>
> + <para>
> + <literal>manual</literal>: The analyze was started by an explicit
>
> For consistency with "started_by" in pg_stat_progress_vacuum, I think
> it's better to start with "The operation was started by".

I think "started_by" in pg_stat_progress_vacuum uses "The vacuum was
started by ...".

> ---
> + <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command>
> + command.
>
> How about using "... or VACUUM with the ANALYZE option"?

Agreed, I've fixed it.

--
Best regards,
Shinya Kato
NTT OSS Center

Attachment Content-Type Size
v9-0001-Add-mode-and-started_by-columns-to-pg_stat_progre.patch application/octet-stream 11.2 KB
v9-0002-Add-started_by-column-to-pg_stat_progress_analyze.patch application/octet-stream 5.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-12-05 04:36:56 Re: Improve error reporting in 027_stream_regress test
Previous Message shveta malik 2025-12-05 03:58:58 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart