| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | lin teletele <teletele(dot)lin(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use pg_current_xact_id() instead of deprecated txid_current() |
| Date: | 2026-06-02 11:21:10 |
| Message-ID: | CAOzEurQLeN198bfnaHxUqdS6O5F-ce4jXhoscV313D9niM89GA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 2, 2026 at 4:14 PM lin teletele <teletele(dot)lin(at)gmail(dot)com> wrote:
>
> Hi Shinya,
>
> Thanks for the updated v5. Looked at v5 — the arithmetic is correct,
> and the tests cover the edges.
Thanks for the review!
> One nit: in-development patches usually pick OIDs in the 8000-9999
> range per bki.sgml, but it's not a big deal — the committer renumbers
> OIDs anyway.
I didn't know that, so I've fixed in v6.
--
Best regards,
Shinya Kato
NTT OSS Center
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Add-arithmetic-operators-for-xid8.patch | application/octet-stream | 10.8 KB |
| v6-0002-Use-pg_current_xact_id-instead-of-deprecated-txid.patch | application/octet-stream | 13.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2026-06-02 11:59:35 | Re: Heads Up: cirrus-ci is shutting down June 1st |
| Previous Message | solai v | 2026-06-02 11:10:25 | Re: Add pg_get_publication_ddl function |