Re: [PATCHES] Post-special page storage TDE support

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: [PATCHES] Post-special page storage TDE support
Date: 2023-01-25 00:38:50
Message-ID: CAOxo6XJXTh5O9oQA9zJgTTLybwWNQ8eq-Fpvwtd-5pJO2tBEog@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

So here is a v3 here, incorporating additional bug fixes and some
design revisions. I have narrowed this down to 3 patches, fixing the
bugs that were leading to the instability of the specific test file so
dropping that as well as removing the useless POC "wasted space".

The following pieces are left:

0001 - adjust the codebase to utilize the "reserved_page_space"
variable for all offsets rather than assuming compile-time constants.
This allows us to effectively allocate a fixed chunk of storage from
the end of the page and have everything still work on this cluster.
0002 - add the Page Feature abstraction. This allows you to utilize
this chunk of storage, as well as query for feature use at the page
level.
0003 - the first page feature, 64-bit encryption (soon to be
renumbered when GCM storage for TDE is introduced, though the two
features are designed to be incompatible). This includes an
arbitrarily found 64-bit checksum, so we probably will need to write
our own or ensure that we have something license-compatible.

This is rebased and current as-of-today and passes all CI tests, so
should be in a good place to start looking at.

Best,

David

Attachment Content-Type Size
v3-0003-Add-page-feature-for-64-bit-checksums.patch application/octet-stream 35.1 KB
v3-0002-Add-Page-Features-optional-per-page-storage-alloc.patch application/octet-stream 51.7 KB
v3-0001-Add-reserved_page_space-to-Page-structure.patch application/octet-stream 68.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-25 00:42:06 Re: 011_crash_recovery.pl intermittently fails
Previous Message Michael Paquier 2023-01-25 00:34:43 Re: 011_crash_recovery.pl intermittently fails