Re: pgsql: In AlterRole, make bypassrls an int

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: In AlterRole, make bypassrls an int
Date: 2015-08-21 17:41:23
Message-ID: CAOuzzgrsC4t3T6yaSh=Md24hDL4E5hUSM6YEt2Yp8tJKmEvWDw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Friday, August 21, 2015, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> Stephen Frost wrote:
>
> > Add regression tests to test CREATE/ALTER role for the various role
> > attributes. Arrange to leave roles behind for testing pg_dumpall, but
> > none which have the LOGIN attribute.
>
> There is a problem in this test, which is that it throws errors if the
> roles already exist. Maybe CREATE IF NOT EXISTS is needed, or perhaps
> a DROP beforehand?
>

Right, not sure it's that simple since we don't want the output to differ
based on if they exist already or not. Might be able to adjust the log
level to address that, or a DO block which handles it if nothing else
works.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2015-08-21 19:51:50 pgsql: Clean up roles from roleattributes test
Previous Message Alvaro Herrera 2015-08-21 17:40:23 pgsql: Do not allow *timestamp to be passed as NULL