Re: Warnings around booleans

On Friday, August 21, 2015, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Stephen Frost <sfrost(at)snowman(dot)net <javascript:;>> writes:
> > On Friday, August 21, 2015, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me
> <javascript:;>>
> > wrote:
> >> If I'm not mistaken, the roles introduced in this test are never
> dropped,
> >> which will cause the test to fail on consequent runs.
>
> > Ah, I was thinking there was a reason to not leave them around but
> couldn't
> > think of it and liked the idea of testing the pg_dumpall / pg_upgrade
> code
> > paths associated.
>
> > Perhaps the way to address this is to add a bit of code to drop them if
> > they exist? That would be reasonably straight-forward to do, I believe.
>
> It is not really acceptable to leave roles hanging around after "make
> installcheck"; that would be a security hazard for the installation.
> Please drop them.
>

The only ones which were left were intentionally all NOLOGIN to address
that concern, which I had considered. Is there another issue with them
beyond potential login that I'm missing?

Thanks,

Stephen