Re: Possibility to disable `ALTER SYSTEM`

From: Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Joel Jacobson <joel(at)compiler(dot)org>, Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, Magnus Hagander <magnus(dot)hagander(at)redpill-linpro(dot)com>
Subject: Re: Possibility to disable `ALTER SYSTEM`
Date: 2024-03-27 19:10:02
Message-ID: CAOtHd0BzfNFOpNW=WABBknEnPB4Zoi2tUVhdE_SE803yU2gDkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 27, 2024, 11:46 Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Wed, Mar 27, 2024 at 1:12 PM Isaac Morland <isaac(dot)morland(at)gmail(dot)com>
> wrote:
> > On Wed, 27 Mar 2024 at 13:05, Greg Sabino Mullane <htamfids(at)gmail(dot)com>
> wrote:
> >>> The purpose of the setting is to prevent
> <emphasis>accidental</emphasis> modifications via <literal>ALTER
> SYSTEM</literal> in environments where
> >> The emphasis on 'accidental' seems a bit heavy here, and odd. Surely,
> just "to prevent modifications via ALTER SYSTEM in environments where..."
> is enough?
> > Not necessarily disagreeing, but it's very important nobody ever mistake
> this for a security feature. I don't know if the extra word "accidental" is
> necessary, but I think that's the motivation.
>
> I think the emphasis is entirely warranted in this case.

+1. And while "non-malicious" may technically be more correct, I don't
think it's any clearer.

>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2024-03-27 19:37:50 Re: BitmapHeapScan streaming read user and prelim refactoring
Previous Message Nathan Bossart 2024-03-27 18:57:16 Re: add AVX2 support to simd.h