| From: | Karen Jex <karenhjex(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Peter Eisentraut <peter(at)eisentraut(dot)org>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, xavier_fischer(at)hotmail(dot)fr |
| Subject: | Re: Good beginner doc-hacking task: clear-text vs. cleartext vs. clear text vs. plaintext etc.. |
| Date: | 2026-11-17 08:49:52 |
| Message-ID: | CAOpR_fZf5J867ubm8gxzB_hHhRkCGqc_WfwG=HzOZz9Q0SUU0Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
Le lun. 16 nov. 2026 à 10:22, Daniel Gustafsson <daniel(at)yesql(dot)se> a écrit :
>
> > On 13 Nov 2026, at 10:14, Karen Jex <karenhjex(at)gmail(dot)com> wrote:
>
> > Commitfest entry: https://commitfest.postgresql.org/patch/7630/
>
> Thanks for the new version, I think this is pretty much done, just a few small
> comments from reviewing it again:
>
> user passwords to connect to the remote server. This avoids storing
> - plain-text user passwords in PostgreSQL system catalogs.
> + cleartext user passwords in PostgreSQL system catalogs.
>
> ..and:
>
> - plain-text user passwords to connect to the remote server. This
> - avoids storing plain-text user passwords in PostgreSQL system
> + cleartext user passwords to connect to the remote server. This
> + avoids storing cleartext user passwords in PostgreSQL system
>
> I think there is potential for additional cleanup here since it is the storage
> system we are referring to and not an inherent quality of a specific password.
> Something like the below (though I don't particularly like the double "in", but
> I fail at english today) would be an improvement I think.
>
> "This avoids storing user passwords in cleartext in PostgreSQL system
> catalogs."
+1 This makes it clearer. I don't mind the double "in" - I can't think
of a better alternative.
>
> Attachec v4 have the above changes plus a needed rebase since the pg_dump hunk
> didn't apply anymore.
Thank you for doing this. I agree with all of your changes.
--
Karen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-11-17 09:28:40 | Re: Introductory docs-hacking task: Example markup |
| Previous Message | David G. Johnston | 2026-11-17 05:20:25 | Re: Introductory docs-hacking task: Example markup |