Re: Resql test cases for views and fix for bug: 4650

From: Usman Muzaffar <usman(dot)muzaffar(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Resql test cases for views and fix for bug: 4650
Date: 2019-08-27 14:31:44
Message-ID: CAOiUKEP1z-QajyDqBf6Kvbh2K5hfEZFPd_WWYHWQqtG5B82imQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,
Please find here updated patch with the above required test cases.

Please review and commit the changes

On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Usman
>
> I have modified the code, please work on the following test cases:
>
> - No test case for privileges at all.
> - We should add alter test cases for check_option, security_barrier
> and privileges.
>
> Attached is the modified patch, please continue your work on it.
>
> On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar <
> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>
>> Just a correction, bug reference in above mail should be *4486* instead
>> of *4650*.
>>
>> On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <
>> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find here attached patch for sql re engineering test cases for
>>> views node. As part of this patch I have also incorported followings
>>>
>>> - Fix for bug # 4650
>>> - Also modified views/template/create.sql due to which, apparently
>>> same output and input was not matching for test cases.
>>>
>>> Following are verified before sending the patch
>>>
>>> - yarn run pep8
>>> - verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and
>>> ppas 9.4 to 11.
>>>
>>>
>>> --
>>>
>>>
>>> Thanks,
>>>
>>> Usman Muzaffar
>>> QA Team
>>> EnterpriseDB Corporation
>>>
>>
>>
>> --
>>
>>
>> Thanks,
>>
>> Usman Muzaffar
>> QA Team
>> EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--

Thanks,

Usman Muzaffar
QA Team
EnterpriseDB Corporation

Attachment Content-Type Size
view_re_sql_testcases_v3.patch application/octet-stream 22.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-08-28 05:16:36 pgAdmin 4 commit: Fix query tool launch error if user name contain html
Previous Message Akshay Joshi 2019-08-27 14:25:05 pgAdmin 4 commit: Fixed timezone issue in RE-SQL test cases for Roles.