| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, jeevanladhe(dot)os(at)gmail(dot)com |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-01-31 14:24:28 |
| Message-ID: | CAOgcT0PCZ-2Gex1n9Ob+FAirStFmMXiiFxXQU1+=y1+G60UoQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I think you are right, I have removed the message and again introduced
> the Assert() back.
>
In my previous version of patch, this was a problem, basically, there should
not be an assert as the code is still reachable be it server-lz4 or
client-lz4.
I removed the assert and added the level range check there similar to gzip.
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Add-a-LZ4-compression-method-for-server-side-compres.patch | application/octet-stream | 19.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-31 14:32:21 | Re: make MaxBackends available in _PG_init |
| Previous Message | Sergey Dudoladov | 2022-01-31 14:11:56 | Re: Add connection active, idle time to pg_stat_activity |