On Wed, Mar 10, 2021 at 10:44 AM Bharath Rupireddy <
bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> Hi,
>
> While providing thoughts on [1], I observed that the error messages
> that are emitted while adding foreign, temporary and unlogged tables
> can be improved a bit from the existing [2] to [3].
>
+1 for improving the error messages here.
> Attaching a small patch. Thoughts?
>
I had a look at the patch and it looks good to me. However, I think after
you have added the specific kind of table type in the error message itself,
now the error details seem to be giving redundant information, but others
might
have different thoughts.
The patch itself looks good otherwise. Also the make check and postgres_fdw
check looking good.
Regards,
Jeevan Ladhe