Re: refactoring basebackup.c

From: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
To: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2021-12-28 07:41:53
Message-ID: CAOgcT0NH+DRkj6pr51DsYyPg73Fuj-uLpr707akfZcbaxTqdvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tushar,

You need to apply Robert's v10 version patches 0002, 0003 and 0004, before
applying the lz4 patch(v8 version).
Please let me know if you still face any issues.

Regards,
Jeevan Ladhe

On Mon, Dec 27, 2021 at 7:01 PM tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
wrote:

> On 11/22/21 11:05 PM, Jeevan Ladhe wrote:
> > Please find the lz4 compression patch here that basically has:
> Thanks, Could you please rebase your patch, it is failing at my end -
>
> [edb(at)centos7tushar pg15_lz]$ git apply /tmp/v8-0001-LZ4-compression.patch
> error: patch failed: doc/src/sgml/ref/pg_basebackup.sgml:230
> error: doc/src/sgml/ref/pg_basebackup.sgml: patch does not apply
> error: patch failed: src/backend/replication/Makefile:19
> error: src/backend/replication/Makefile: patch does not apply
> error: patch failed: src/backend/replication/basebackup.c:64
> error: src/backend/replication/basebackup.c: patch does not apply
> error: patch failed: src/include/replication/basebackup_sink.h:285
> error: src/include/replication/basebackup_sink.h: patch does not apply
>
> --
> regards,tushar
> EnterpriseDB https://www.enterprisedb.com/
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-12-28 07:59:19 Re: Add Boolean node
Previous Message Bharath Rupireddy 2021-12-28 06:58:07 Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?