From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: block-level incremental backup |
Date: | 2019-09-02 07:39:39 |
Message-ID: | CAOgcT0M0CECm-Zu=DKDtDwos5F4qpkQ9CU9GEkoCyBj+wbZYJQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Robert,
On Sat, Aug 31, 2019 at 8:29 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Aug 29, 2019 at 10:41 AM Jeevan Ladhe
> <jeevan(dot)ladhe(at)enterprisedb(dot)com> wrote:
> > Due to the inherent nature of pg_basebackup, the incremental backup also
> > allows taking backup in tar and compressed format. But, pg_combinebackup
> > does not understand how to restore this. I think we should either make
> > pg_combinebackup support restoration of tar incremental backup or
> restrict
> > taking the incremental backup in tar format until pg_combinebackup
> > supports the restoration by making option '--lsn' and '-Ft' exclusive.
> >
> > It is arguable that one can take the incremental backup in tar format,
> extract
> > that manually and then give the resultant directory as input to the
> > pg_combinebackup, but I think that kills the purpose of having
> > pg_combinebackup utility.
>
> I don't agree. You're right that you would have to untar (and
> uncompress) the backup to run pg_combinebackup, but you would also
> have to do that to restore a non-incremental backup, so it doesn't
> seem much different.
>
Thanks. Yes I agree about the similarity between restoring non-incremental
and incremental backup in this case.
> I don't think it's worth doing that at this point; I definitely don't
> think it
> needs to be part of the first patch.
>
Makes sense.
Regards,
Jeevan Ladhe
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-09-02 07:57:10 | Re: [HACKERS] CLUSTER command progress monitor |
Previous Message | Michael Paquier | 2019-09-02 06:51:34 | Re: SIGQUIT on archiver child processes maybe not such a hot idea? |