| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [oauth] Bug: when is shutdown_cb called? |
| Date: | 2026-02-27 16:55:41 |
| Message-ID: | CAOYmi+ncsyQiODCv+7-EnQ4pTd7NuZhKV7s+_m7QGCMe4HfH9A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 18, 2026 at 4:50 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> Maybe we should just fix the documentation instead?
Yeah, this is just a docs bug. It changed in v47 of the original
patchset [1] but I forgot to update the documentation. (It was
originally a before_shmem_exit implementation, which is why that fits
the description well. :D)
I propose the attached diff, with a backport to 18.
> The advantages: things like expiration checks[2], or repeated
> validation in the future when we implement token refresh need a
> working validator state, which means either we have to call
> startup/shutdown multiple times, or keep the context.
Personally I think it's fine for more complicated behavior to require
more integration into the existing server APIs. We don't need to
reinvent OAuth-specific wheels; implementations will just need to pay
attention to memory contexts and _PG_init like standard extensions
already do.
Thanks,
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| shutdown-docs.diff | application/octet-stream | 961 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-02-27 17:00:17 | Re: doc: Clarify that empty COMMENT string removes the comment |
| Previous Message | Peter Eisentraut | 2026-02-27 16:52:46 | Re: Make copyObject work in C++ |