Re: pg_createsubscriber does not check output_plugin_libraries

On Wed, Sep 9, 2026 at 3:33 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> Thanks for giving feedbacks. I'm confusing and let me confirm few points.
> The situation might be different before and after the PG19.

Oh, that's a good point.

> In this thread I do not want to broaden for other points and focus on the added
> GUC, thought? In other threads we can improve --check option more.

As long as everyone is in agreement that --dry-run *should* be
performing those checks in the first place, I'm happy. I just wasn't
sure from looking at the code if it was intended to perform any
permissions checks at all, so I was trying to figure out what my
original patch should have done differently.

Even for PG17, specifying a non-superuser in the connection string
leads to a successful --dry-run, then fails during normal operation.
If our answer to that is "don't do that in the back branches", fine by
me -- but then we could also say "don't remove pgoutput from
output_plugin_libraries and then be surprised when all subscription
operations fail." (The role of each builtin plugin should probably be
better explained in the documentation for output_plugin_libraries,
since this is a brand-new consideration for most people...)

Thanks,
--Jacob