| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Dave Cramer <davecramer(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Correct documentation for protocol version |
| Date: | 2026-06-30 16:48:50 |
| Message-ID: | CAOYmi+n0F0D2VHZucKbfZ0gH0Tw87dtChbgNYWDYihsVh8xMvQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 8, 2026 at 12:27 PM Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
> After Jacob made his changes to the "Protocol Versions" section in
> e3d37853ecd, now seemed a good moment to update this patch to do the
> proposed.
I'm more than happy to remove the v2 information -- though we may want
to keep the v2 error format somewhere, if it's not already in the
startup flow description -- and I agree we should document the
NegotiateProtocolVersion history. ("9.3.21 and later" is misleading,
though; see a60a10338 and its thread.)
The discussion of the sslnegotiation=direct changes needs refinement,
IMO. All we did there was add raw TLS support on the same port;
negotiation of the protocol version happens via TLS in that case. (To
put it another way: clients and servers don't have to support that in
order to claim protocol 3.0 compliance.)
We could instead document the fact that the initial TLS 1.x packets
can be disambiguated from StartupMessages on the wire, which is what
lets us run the two separate protocols on a single port. We could also
document our ALPN requirements for that mode, or link to the
"protocol-flow-ssl" id in the docs.
Thanks!
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-06-30 17:00:12 | Re: occasional ECPG failures on dikkop (FreeBSD) |
| Previous Message | Tomas Vondra | 2026-06-30 16:33:00 | Re: occasional ECPG failures on dikkop (FreeBSD) |