| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: pgsql: libpq: Grease the protocol by default |
| Date: | 2026-02-24 20:29:02 |
| Message-ID: | CAOYmi+mFbpQ50KjV48-M0YarZjHDLEXXtqhzy-BuXseRPU5D9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Feb 24, 2026 at 10:58 AM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> We do store (the major version part of) `pg_ctl --version` at some
> point, which we could improve upon, but I agree that adding additional
> complexity here doesn't actually give us any benefit.
Okay, here are the patches I propose. The ones for 18-HEAD check for
PG10 and below, and 14-17 additionally check that libpq >= 18, before
adding max_protocol_version=3.0.
I smoke-tested upgrades from 9.2, 10.1, and 11.0 for all six branches,
and then re-ran that test matrix with pg_upgrade linked against a
greased libpq.
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.patch | application/octet-stream | 5.0 KB |
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.18.patch | application/octet-stream | 5.0 KB |
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.17.patch | application/octet-stream | 4.9 KB |
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.16.patch | application/octet-stream | 5.1 KB |
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.15.patch | application/octet-stream | 5.1 KB |
| v2-0001-pg_upgrade-Use-max_protocol_version-3.0-for-older.14.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-24 20:40:38 | Re: pgsql: libpq: Grease the protocol by default |
| Previous Message | Jacob Champion | 2026-02-24 18:58:30 | Re: pgsql: libpq: Grease the protocol by default |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-24 20:40:38 | Re: pgsql: libpq: Grease the protocol by default |
| Previous Message | Tom Lane | 2026-02-24 20:21:05 | Re: Wrong results with grouping sets |