Re: [PATCH] Fix missing comma in Requires.private with a Make macro

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, fabriziomello(at)gmail(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Wolfgang Walther <walther(at)technowledgy(dot)de>
Subject: Re: [PATCH] Fix missing comma in Requires.private with a Make macro
Date: 2025-05-08 15:29:49
Message-ID: CAOYmi+mD3Fexa8mJ82Bf5JWSW8bumTt2vgFmUjHx-hXC8sVgAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 7, 2025 at 3:39 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> Well, Jacob did say that he tested it with 3.81, so this patch should be
> okay. Upping the minimum version can be discussed elsewhere ... or
> maybe never, if we end up replacing it wholesale with Meson/ninja.

To be fair, I did invite debate. I don't mind if it happens here. :D

Sounds like the debate might be fairly short, though. I was hoping the
choice of Make came from that old Debian box. But since it's actually
coming from Apple and I guess they have no plans to ever update... I
don't think you all need to change macOS setups on my account. I'd
imagine that people are not writing new Makefile macros very often.

Is there maybe a wiki page where we gather the reasoning for our
pinned minimum versions? None of my searches turned anything up, but
it might help accelerate some of these conversations.

Thanks!
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-05-08 15:45:04 Re: [PATCH] oauth: Prevent stack overflow by limiting JSON parse depth
Previous Message Nathan Bossart 2025-05-08 15:19:52 Re: regdatabase