Re: pgsql: oauth: Add unit tests for multiplexer handling

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: oauth: Add unit tests for multiplexer handling
Date: 2025-08-08 17:05:51
Message-ID: CAOYmi+m=xY0P_uAzAP_884uF-GhQ3wrineGwc9AEnb6fYxVqVQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Aug 8, 2025 at 10:01 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Yeah, that's a horrid kluge. The makefiles themselves ought to
> short-circuit building the test program. I think the issue is that
> we apply that short-circuit at the next makefile level up --- can
> we do it in src/interfaces/libpq-oauth/Makefile itself?

I'm working on an ifeq test to do that, but some Meson animals are
also reporting issues:

/usr/bin/ld: test-oauth-curl.o: undefined reference to symbol
'floor@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/libm.so.6: error adding symbols:
DSO missing from command line
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This is not fully baked enough. I'll revert the test commit for now;
today is not the day to make other people fight a red farm.

--Jacob

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jacob Champion 2025-08-08 17:17:54 pgsql: Revert "oauth: Add unit tests for multiplexer handling"
Previous Message Tom Lane 2025-08-08 17:01:07 Re: pgsql: oauth: Add unit tests for multiplexer handling