Re: Serverside SNI support in libpq

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Dewei Dai <daidewei1970(at)163(dot)com>, "li(dot)evan(dot)chao" <li(dot)evan(dot)chao(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Serverside SNI support in libpq
Date: 2026-03-18 16:14:02
Message-ID: CAOYmi+m+Om21ej2tf6xu6zRr2dBaddyodC0JG0i5aCH6NR74fA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 18, 2026 at 7:25 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> The longfin issue is a bit more odd, I can reproduce it on macOS with OpenSSL
> 1.1.1 but nowhere else. Rather than reporting an SSL error for aborted
> handshake it reports a SYSCALL error.

Do you know yet why the handshake is aborted on macOS, as opposed to a
polite handshake_failure alert?

> The change in the attached diff does fix it for me but I'm
> a bit hesitant to apply something like that, I would be more inclined to the
> change the expected output in the test. What are your thoughts?

I think that patch might effectively shadow the `else` branch, which
is supposed to be reporting the EOF. (I wouldn't mind a better error
message than "SYSCALL error: EOF detected", but that's not something
this patch did.)

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Artur Zakirov 2026-03-18 16:21:06 Order of InvokeObjectPostAlterHook within ATExecSetNotNull
Previous Message Nathan Bossart 2026-03-18 16:09:31 Re: another autovacuum scheduling thread