Re: [PoC] Federated Authn/z with OAUTHBEARER

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ivan Kush <ivan(dot)kush(at)tantorlabs(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, lev(dot)nikolaev(at)tantorlabs(dot)com
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Date: 2025-07-09 19:28:52
Message-ID: CAOYmi+kps=uRhx==UjmE2smqgjvigTRemxK5W=WfQ1MCA0ReiQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 9, 2025 at 12:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> > Here is a draft patch for Ivan's reported issue; I still need to put
> > it through its paces with some more unusual setups, but I want to get
> > cfbot on it.
>
> I'm confused about why this moves up the temporary changes of
> CPPFLAGS and LDFLAGS, but not LIBS? Maybe that's actually correct,
> but it looks strange (and perhaps deserves a comment about why).

Yeah, that's fair. It's because LIBCURL_LDLIBS isn't set until that
AC_CHECK_LIB test is run, and the test needs LIBCURL_LDFLAGS to be in
force.

(Upthread, I was idly wondering if those AC_CHECKs should just be
removed -- after all, PKG_CHECK_MODULES just told us where Curl was --
but I'm nervous that this might make more niche use cases like
cross-compilation harder to use in practice?)

Does the attached help clarify?

Thanks,
--Jacob

Attachment Content-Type Size
v2-0001-WIP-oauth-run-Autoconf-tests-with-correct-compile.patch application/octet-stream 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-07-09 19:30:15 Re: 回复:[Internet]Re: [PATCH] Prevent replacement of a function if it's used in an index expression and is not IMMUTABLE
Previous Message Nathan Bossart 2025-07-09 19:26:37 Re: CHECKPOINT unlogged data