| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Improve OAuth discovery logging |
| Date: | 2026-02-24 23:24:23 |
| Message-ID: | CAOYmi+kjtmRMBdBU3_bGKGDoRSK2AErXbGtHkAjFRapcQNmjhA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Feb 13, 2026, at 21:13, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> > Maybe something like PG_SASL_EXCHANGE_ABANDONED?
>
> This is the only one I wasn't sure of, I used RESTART because I was
> focusing more on the intention of the server ("please restart
> authentication with this additional information"), and a bit also on
> the idea that later restart could stay even within the same
> connection, both in this case and if we add support for
> reauthentication on token expiration.
I think "abandoned" would still work as a descriptor if we eventually
supported multiple SASL exchanges per connection.
On Mon, Feb 23, 2026 at 7:01 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Looks like you forgot to update the commit message to change PG_SASL_EXCHANGE_RESTART to PG_SASL_EXCHANGE_ABANDONED.
Yes -- though keep in mind that committers will often rewrite commit
messages from scratch. So while keeping it accurate and well-written
should be the goal, perfection isn't required to move something into
RfC.
Speaking of which: Zsolt, would you mind adding this to the Commitfest?
> "ctx->state = OAUTH_STATE_FINISHED;" is duplicated in the “if” and after the “if”, so it can be pull up to before the “if”.
+1
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-24 23:30:35 | Re: pgsql: libpq: Grease the protocol by default |
| Previous Message | Jacob Champion | 2026-02-24 22:59:04 | Re: pgsql: libpq: Grease the protocol by default |