[PATCH] Fix OAuth feature detection on OpenBSD+Meson

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH] Fix OAuth feature detection on OpenBSD+Meson
Date: 2025-06-23 23:36:22
Message-ID: CAOYmi+kdR218ke2zu74oTJvzYJcqV1MN5=mGAPqZQuc79HMSVA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I noticed that the OpenBSD build in CI wasn't running the libcurl
tests. Turns out the feature test I added in b0635bfda is subtly
broken, because it uses cc.check_header() rather than cc.has_header().
On OpenBSD, apparently, the <sys/event.h> header can't be compiled
without including additional prerequisite headers.

The attached patch fixes that by just switching to has_header(). (I
could add the prerequisites to the test instead, but I'd prefer to
exactly match the logic we use to determine the value of the
HAVE_SYS_EVENT_H macro. I don't think I had a good reason not to in
the first place.)

As a potential follow-up, is there any interest in switching the
Cirrus Meson setup to explicitly enable the features that we expect to
test? That would match what we do for Autoconf, I think; it would have
helped me catch my mistake earlier.

Thanks,
--Jacob

Attachment Content-Type Size
0001-oauth-Fix-kqueue-detection-on-OpenBSD.patch application/octet-stream 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2025-06-23 23:44:31 Re: BackendKeyData is mandatory?
Previous Message Noah Misch 2025-06-23 23:16:09 Re: Proper object locking for GRANT/REVOKE