Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, rmt(at)lists(dot)postgresql(dot)org, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Melanie Plageman <melanieplageman(at)gmail(dot)com>
Subject: Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0
Date: 2026-06-16 20:58:04
Message-ID: CAOYmi+=soLWDze13fXv8nfkz9st5c5YeFeumV=-AuPE9eOCyzw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 16, 2026 at 1:12 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> If there is concern over the neatness of this (long term in the backbranches,
> for master it will be reverted as mentioned), I guess one option could be to
> introduce a new binary, oauth_curl_version, which only prints the version and
> exits instead oa adding a flag to an otherwise unrelated binary. It would add
> a little compilation overhead though.

I considered that, but I think adding a second binary to the existing
Makefile is likely to result in build system churn (to get it to
behave like e.g. test_json_parser/Makefile). I can investigate that
path if you think it'd be more maintainable that way, but let's make
sure Tom's point below doesn't moot it:

On Tue, Jun 16, 2026 at 1:40 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I confirm that, with or without 0004, this fixes the oauth_validator
> failure on the machine where I saw that.

Thanks very much!

> However ... I don't love the plan of fixing this differently in v19
> and v20 just because of feature freeze. Exposing more information
> for testing purposes isn't a user-visible feature IMO, so I would
> rather we go straight to 0004.

Fair enough. If the RMT is okay with this for 19, were you thinking
we'd also backpatch that code directly to 18?

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-06-16 21:02:28 Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0
Previous Message Tom Lane 2026-06-16 20:40:50 Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0