Re: libcurl in libpq.pc

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Wolfgang Walther <walther(at)technowledgy(dot)de>
Subject: Re: libcurl in libpq.pc
Date: 2025-05-12 16:08:25
Message-ID: CAOYmi+=n84h7UDD-XUWYCNiMY7ZitmGpOqKFR1ie7PzzQejPDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 12, 2025 at 8:49 AM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Mon, May 12, 2025 at 3:50 AM Christoph Berg <myon(at)debian(dot)org> wrote:
> > Since nothing in libpq should need curl for compiling, should we drop
> > it there instead?
>
> The static build (libpq.a) still needs libcurl. The module is only
> compiled for use by the shared library.

Sorry, typing too fast in the airport. The _clients_ of libpq.a still
need libcurl, after they link libpq-oauth.a for the missing symbols.
Isn't that what Requires.private is for?

--Jacob

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-05-12 18:05:03 Re: Useless LEFT JOIN breaks MIN/MAX optimization
Previous Message Jacob Champion 2025-05-12 15:49:11 Re: libcurl in libpq.pc