Re: [OAuth] Missing dependency on oauth_validator test

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [OAuth] Missing dependency on oauth_validator test
Date: 2026-01-27 20:17:21
Message-ID: CAOYmi+=Jpqsv7_mGLp8oEEfY_y11gG69x-FVttF7KLbBgScNJw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 17, 2026 at 9:31 AM Jonathan Gonzalez V.
<jonathan(dot)abdiel(at)gmail(dot)com> wrote:
> I'm attaching a small patch that add the binary dependency in the
> meson.build file, thus, it will be build before running the test.

Pushed and backpatched, thanks! I missed the conversation in [1],
where this was fixed for the other binaries.

Andres, do you know of any way we could surface these missing deps
with only the "standard" meson/ninja invocations? The only idea I had
was to not build the test executables by default, but I think that
trades a small problem (we occasionally hit a build-time dependency
bug) for a big one (devs fail to notice that a test executable doesn't
compile).

--Jacob

[1] https://postgr.es/m/qh4c5tvkgjef7jikjig56rclbcdrrotngnwpycukd2n3k25zi2%4044hxxvtwmgum

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-01-27 20:26:38 Re: AIX support
Previous Message Konstantin Knizhnik 2026-01-27 20:10:19 Re: Mystery with REVOKE PRIVILEGE