Re: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace

On Mon, Sep 14, 2026 at 4:28 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Thanks for the report, that does indeed seem like the right fix.

Yes, thanks! Couple thoughts on specific pieces:

> + /*
> + * An empty or all-whitespace setting is accepted by
> + * SplitDirectoriesString(), which returns an empty list for it, so the
> + * parse result has to be checked rather than the raw string.
> + */

Sometimes recording a historical bug in the comments can help prevent
future mistakes... but I don't think this is one of those cases,
especially since the new test prevents accidental regression.

> +is($bgconn->query_safe('SELECT 1'), '1',
> + 'postmaster survives an empty OAuth validator list on reload');

query_safe() doesn't return on failure, so IMO we shouldn't wrap it in is().

--

This seems like a good time to mention that I have a checklist item to
fix the following (shouldn't block this patch):

> if (!SplitDirectoriesString(rawstring, ',', &elemlist))
> ...
> if (strcmp(allowed, hbaline->oauth_validator) == 0)

SplitDirectoriesString() canonicalizes its outputs, which we then
compare against the uncanonicalized hbaline->oauth_validator. That
could lead to annoying false negatives in more complicated setups.

Thanks,
--Jacob