| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Few untranslated error messages in OAuth |
| Date: | 2025-12-15 23:06:30 |
| Message-ID: | CAOYmi+=Gurbpx7RFLH4yssLrdw7VBey+kYQ84msKG8iLkRo3qg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2025 at 2:09 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> No strong opinion on JSONAPI_USE_PQEXPBUFFER. As far as I can tell, we
> pretty much force you to link libpq if you want to have a PQExpBuffer,
> which tells me that a frontend jsonapi.c user would already be forced to
> link libpq.
Only the _shlib variant uses JSONAPI_USE_PQEXPBUFFER; the "main"
frontend version doesn't. (pg_combinebackup is an example of a
frontend JSON client that doesn't link against libpq, I think.)
> > For now, I'll proceed as if a backport to 18 is appropriate for these.
>
> Yeah, I'd prefer that.
Committed and backpatched. Thanks for the reviews, thanks everybody
for the thread, and thank you Hou-san for the patch!
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-12-15 23:08:39 | Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers |
| Previous Message | Nathan Bossart | 2025-12-15 23:00:47 | Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB ?barriers |