| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Christoph Berg <myon(at)debian(dot)org>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, Wolfgang Walther <walther(at)technowledgy(dot)de>, Devrim Gündüz <devrim(at)gunduz(dot)org> |
| Subject: | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Date: | 2025-05-02 15:46:21 |
| Message-ID: | CAOYmi+=CgA=RfvhcKgT6k+G=tFBi0BFk1gWsi6jAZ9dSYV0auQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 2, 2025 at 8:11 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> After commit b0635bf, I'm seeing the following meson build failures on
> macOS:
Thanks for the report, and sorry for the breakage.
> In file included from ../postgresql/src/interfaces/libpq-oauth/oauth-curl.c:51:
> ../postgresql/src/interfaces/libpq/libpq-int.h:70:10: fatal error: 'openssl/ssl.h' file not found
> 70 | #include <openssl/ssl.h>
> | ^~~~~~~~~~~~~~~
> 1 error generated.
Hm. My test setup here is Homebrew with -Dextra_include_dirs, which
may explain why it's not failing for me. Looks like Cirrus also has
-Dextra_include_dirs...
> The following patch seems to resolve it. I'm curious if commit 4ea1254
> might apply to meson, too, but FWIW I haven't noticed any related failures
> on my machine.
Yeah, I wonder if libintl is being similarly "cheated" on the Meson side.
> diff --git a/meson.build b/meson.build
> index 29d46c8ad01..19ad03042d3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3295,6 +3295,7 @@ libpq_deps += [
>
> libpq_oauth_deps += [
> libcurl,
> + ssl,
> ]
Thanks! I think the include directory is the only thing needed for the
static library, not the full link dependency. But I'll try to build up
a new Meson setup, with minimal added settings, to see if I can
reproduce here. Can you share your Meson configuration?
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2025-05-02 15:53:04 | Re: extension_control_path and "directory" |
| Previous Message | Bruce Momjian | 2025-05-02 15:38:35 | Re: PG 18 release notes draft committed |