| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: libpq: Bump protocol version to version 3.2 at least until the first/second beta |
| Date: | 2026-01-30 19:03:04 |
| Message-ID: | CAOYmi+=5dSN6waSUDKEbbH82XQ+oqR7U_xYHVW_xXUR5Ta2h9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 30, 2026 at 10:06 AM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> > 2. In my v5 I created a dedicated section header for protocol
> > extensions instead of including it in the extension. I think that's
> > slightly nicer, primarily so you can link to that section from the
> > StartupMessage docs (including the introductory paragraph), instead of
> > having to link to the table.
>
> Agreed, will fix.
Done in v6-0001. v6-0002/3 are the same as v5.
> As long as the consistency provides *clarity*, I'm fine with it; I'm
> just not sure that it does. I'll post a v6 with some screenshots.
screenshot-1.png shows what the combined table looks like under our
website CSS. The indent is still odd, but it looks less jarring when
"themed", IMHO.
v6-0004 is a squash commit that splits the table instead.
screenshot-2.png shows the effect of the split. I really don't like
it, but I won't die on that hill.
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| since-v5.diff.txt | text/plain | 1.6 KB |
| v6-0001-doc-Expand-upon-protocol-versions-and-extensions.patch | application/octet-stream | 6.7 KB |
| v6-0002-libpq-Prepare-for-protocol-grease-during-19beta.patch | application/octet-stream | 5.6 KB |
| v6-0003-libpq-Grease-the-protocol-by-default.patch | application/octet-stream | 9.1 KB |
| v6-0004-squash-doc-Expand-upon-protocol-versions-and-exte.patch | application/octet-stream | 3.5 KB |
| screenshot-1.png | image/png | 84.6 KB |
| screenshot-2.png | image/png | 87.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2026-01-30 19:13:44 | Re: libpq: Bump protocol version to version 3.2 at least until the first/second beta |
| Previous Message | Tom Lane | 2026-01-30 18:54:05 | Re: Refactor how we form HeapTuples for CatalogTuple(Insert|Update) |
